EMI: Show subtitles of judges during Marco's dive - #6994
Merged
Conversation
chkr-private
commented
Oct 30, 2025
Contributor
- when Marco dives and one of the judges announces the dive combination, the subtitles are currently not displayed
- that happens because the judge actor's _visible variable is true, "isInSet()" returns true as well and so _mustPlaceText is set to true
- because of that, TextObject::setText is called with delaySetup = true which causes the setting of the textobject's _lines to be postponed
- since the actor's EffectiveSortOrder is -1, its draw() method is never called, the text object is never placed, its _lines stay empty and the text is never drawn
- this commit fixes the issue by not setting _mustPlaceText when the actor's effective sort order is < 0
- when Marco dives and one of the judges announces the dive combination, the subtitles are currently not displayed - that happens because the judge actor's _visible variable is true, "isInSet()" returns true as well and so _mustPlaceText is set to true - because of that, TextObject::setText is called with delaySetup = true which causes the setting of the textobject's _lines to be postponed - since the actor's EffectiveSortOrder is -1, its draw() method is never called, the text object is never placed, its _lines stay empty and the text is never drawn - this commit fixes the issue by not setting _mustPlaceText when the actor's effective sort order is < 0
Member
|
preferable merge after branch off as common with Grim Fandango |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.