ULTIMA: Reduce sharing of container classes - #7014
Merged
Merged
Conversation
Member
|
First two commits look good to me. I'm not sure on the third - any chance of reviving #5950 ? |
OMGPizzaGuy
reviewed
Nov 11, 2025
| namespace Ultima8 { | ||
|
|
||
| template<class T> | ||
| class Set { |
Member
There was a problem hiding this comment.
Is there a reason to use this over "common/std/set.h" ?
Member
Author
There was a problem hiding this comment.
I don't know, but the two classes are implemented differently and replacing the use of it in Ultima 8 is a bit more involved, so I'll leave replacing it to someone else.
Member
There was a problem hiding this comment.
OK, I believe the sets were only used in checking for duplicate processes the load game and for the debugging traces for usecode - I'll look into this soon and replace them if that's all.
Member
|
Thanks! Great work. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined with PR #7012, this should make it possible to remove
shared/std/containers.handshared/std/string.hentirely.