MADE: Add save metadata support - #7847
Draft
synacktic wants to merge 1 commit into
Draft
Conversation
The MADE engine could read and write saves but did not expose them to the launcher. Implement save listing, deletion, and metadata queries, and advertise the corresponding engine features. Return to Zork saves contain an SGAM header with a fixed-width, possibly unterminated description. Read that description safely. Older MADE games have no description field, so use the slot number as a fallback. Tested with saves created by the original DOS interpreter; the launcher displays their descriptions. Assisted-by: Claude:claude-opus-5 Assisted-by: Codex:gpt-5
Member
|
Why is this in a draft status? What is still left to be done? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MADE engine reads and writes saves but does not expose them to the
launcher. This adds save listing, deletion, and metadata queries and
advertises the corresponding metaengine features.
Return to Zork saves carry the player's description in a fixed-width,
possibly unterminated field in their original SGAM header. Older MADE
save formats have no description field and fall back to the slot
number.
Testing:
player-entered descriptions.