SKY: Implement intro/outro videos and stretch graphics in ibass - #7850
Open
Priyanshu3820 wants to merge 2 commits into
Open
SKY: Implement intro/outro videos and stretch graphics in ibass#7850Priyanshu3820 wants to merge 2 commits into
Priyanshu3820 wants to merge 2 commits into
Conversation
mgerhardy
reviewed
Aug 19, 2026
| _text->setSprite(NULL); | ||
| } | ||
| Common::Point mouse = _system->getEventManager()->getMousePos(); | ||
| if (SkyEngine::isIbass()) { |
Contributor
There was a problem hiding this comment.
maybe something like void scaleCoordinates(Common::Point &point) which would be nop for non ibass would reduce the code duplication a little bit here?
Contributor
Author
There was a problem hiding this comment.
sure, good idea
Priyanshu3820
force-pushed
the
intro-impl
branch
2 times, most recently
from
August 19, 2026 13:27
8a6f88e to
aec40d1
Compare
Member
|
Please rebase |
Priyanshu3820
force-pushed
the
intro-impl
branch
from
August 25, 2026 06:10
94e0d5d to
26e6d92
Compare
Priyanshu3820
force-pushed
the
intro-impl
branch
from
August 25, 2026 06:14
26e6d92 to
856c045
Compare
Contributor
Author
done @sev-, but now since hotspots are implemented, they need scaling too along with the hint window. I will come back to it. Until then, please don't merge it. |
bluegr
marked this pull request as draft
August 27, 2026 19:02
Contributor
Author
|
done, @sev- |
Priyanshu3820
marked this pull request as ready for review
August 31, 2026 08:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.