Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ALL: add missing include guards - #7851

Open
meekee7 wants to merge 1 commit into
scummvm:masterfrom
meekee7:jan-include-guards
Open

ALL: add missing include guards#7851
meekee7 wants to merge 1 commit into
scummvm:masterfrom
meekee7:jan-include-guards

Conversation

@meekee7

@meekee7 meekee7 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor
  • Add missing include guards to header files
  • Move include guards to be the first code in the file

Notably, a lot of detection_tables.h files were missing include guards. A possible cause is the missing include guard in the corresponding template file from create_engine. That is also resolved here.

Assisted-by: Copilot:GPT-5-Mini Resharper clang-tidy

@sev-

sev- commented Aug 18, 2026

Copy link
Copy Markdown
Member

detection_tables.h is by design. Please remove it.

Assisted-by: Copilot:GPT-5-Mini Resharper clang-tidy
@meekee7
meekee7 force-pushed the jan-include-guards branch from d754c21 to 4d71b81 Compare August 19, 2026 17:21
@meekee7

meekee7 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

detection_tables.h is by design. Please remove it.

All changes to detection_tables.h have been removed. But the code base is inconsistent, some detection_tables.h already have include guards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants