Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ivirshup
Copy link
Member

Adding a few commits to #1066

atarashansky and others added 12 commits April 15, 2020 14:41
This commit cleans up the code for computing a PCA. The changes include:

* Moving PCA specific code to it's own file
* Changing import locations for pca, now they should all import from where it's publically exported
* There is no argument for using implicit centering of a sparse matrix. If you want to compute a pca on a dense array, pass a dense array.
* Having the constant value N_PCs be defined once in it's own file.
* Documenting the change to sparse computation of a PCA
@ivirshup ivirshup merged commit f6a49e8 into scverse:master Apr 15, 2020
@ivirshup ivirshup deleted the sparse-pca branch April 15, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant