Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dkropachev
Copy link
Collaborator

following code:

.update(
            bin_map__remove={123, 456}
        )

Would fail if map is defined with non-nullable value type:

columns.Map(columns.BigInt, columns.Bytes, required=False, default={})

Fixes: #431

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@dkropachev
Copy link
Collaborator Author

@artemki2077, can you please confirm if this fix solves your issue.

following code:
```
.update(
            bin_map__remove={123, 456}
        )
```
Would fail if map is defined with non-nullable value type:
```
columns.Map(columns.BigInt, columns.Bytes, required=False, default={})
```
@dkropachev dkropachev force-pushed the dk/fix-cqlengine-map-remove-for-non-nullable-values branch from cd59ba2 to 97a915c Compare February 23, 2025 03:40
@artemki2077
Copy link

@artemki2077, can you please confirm if this fix solves your issue.

yes, everything is fine with these changes, the same code runs without errors, thank you)

@dkropachev
Copy link
Collaborator Author

@artemki2077, can you please confirm if this fix solves your issue.

yes, everything is fine with these changes, the same code runs without errors, thank you)

Thanks for reporting it and pushing it to the end.

@dkropachev dkropachev requested a review from fruch February 23, 2025 10:34
Copy link

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

was this reported upstream ?

@dkropachev
Copy link
Collaborator Author

LGTM,

was this reported upstream ?

Yes, it was

@dkropachev dkropachev merged commit 7304ae0 into scylladb:master Feb 24, 2025
21 checks passed
@artemki2077
Copy link

when will there be a new release on PyPI with this fix?

@dkropachev
Copy link
Collaborator Author

when will there be a new release on PyPI with this fix?

In next couple of days, I will update you when it is ready

@artemki2077
Copy link

Is there any news when the new version will be released?

@dkropachev
Copy link
Collaborator Author

Is there any news when the new version will be released?

Sorry, but due to bug in releasing code it is delayed, we are looking for workaround

@artemki2077
Copy link

Oh) cool, thanks for the new release)

@dkropachev
Copy link
Collaborator Author

Oh) cool, thanks for the new release)

Just in case, 3.29.2 is what you are looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cqlengine __remove feature does not work for non-nullable values

3 participants