-
Notifications
You must be signed in to change notification settings - Fork 49
cqlengine: fix map remove feature for non-nullable values #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cqlengine: fix map remove feature for non-nullable values #432
Conversation
|
@artemki2077, can you please confirm if this fix solves your issue. |
following code:
```
.update(
bin_map__remove={123, 456}
)
```
Would fail if map is defined with non-nullable value type:
```
columns.Map(columns.BigInt, columns.Bytes, required=False, default={})
```
cd59ba2 to
97a915c
Compare
yes, everything is fine with these changes, the same code runs without errors, thank you) |
Thanks for reporting it and pushing it to the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
was this reported upstream ?
Yes, it was |
|
when will there be a new release on PyPI with this fix? |
In next couple of days, I will update you when it is ready |
|
Is there any news when the new version will be released? |
Sorry, but due to bug in releasing code it is delayed, we are looking for workaround |
|
Oh) cool, thanks for the new release) |
Just in case, 3.29.2 is what you are looking for. |
following code:
Would fail if map is defined with non-nullable value type:
Fixes: #431
Pre-review checklist
I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.Fixes:annotations to PR description.