Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Optimise shard port allocator #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2025
Merged

Optimise shard port allocator #506

merged 2 commits into from
Jul 16, 2025

Conversation

@dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Jul 15, 2025 •
edited
Loading

While I was working on other issue, I have found that code of ShardawarePortGenerator is suboptimal in regards of performance.

So, this PR:

  1. Makes ShardawarePortGenerator testable
  2. Adds unit test for ShardawarePortGenerator
  3. Optimise ShardawarePortGenerator

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@dkropachev dkropachev force-pushed the dk/shard-port-allocator-less-iteration branch from 3cc726f to b5f3921 Compare July 15, 2025 23:01
@dkropachev dkropachev requested a review from Lorak-mmk July 15, 2025 23:01
@dkropachev dkropachev self-assigned this Jul 15, 2025
@dkropachev
Add unit-tests for ShardAwarePortGenerator
cea5fad 
1. Make it testable
2. Add unit tests for it
@dkropachev dkropachev force-pushed the dk/shard-port-allocator-less-iteration branch from b5f3921 to e18144d Compare July 16, 2025 02:42
Lorak-mmk
Lorak-mmk reviewed Jul 16, 2025
View reviewed changes
@dkropachev dkropachev force-pushed the dk/shard-port-allocator-less-iteration branch from e18144d to 4df5863 Compare July 16, 2025 14:13
@dkropachev dkropachev requested a review from Lorak-mmk July 16, 2025 14:13
Lorak-mmk
Lorak-mmk approved these changes Jul 16, 2025
View reviewed changes
Copy link

@Lorak-mmk Lorak-mmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually made a typo as well, sorry! It should be beginning, not beggining.
This is of course not important, so if you don't want to change it its fine.

@dkropachev
Optimise ShardAwarePortGenerator
561422c 
Make ShardAwarePortGenerator iterate only over matching ports.
@dkropachev dkropachev force-pushed the dk/shard-port-allocator-less-iteration branch from 4df5863 to 561422c Compare July 16, 2025 14:32
@dkropachev dkropachev merged commit c7ca1c6 into scylladb:master Jul 16, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lorak-mmk Lorak-mmk Lorak-mmk approved these changes

Assignees

@dkropachev dkropachev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkropachev @Lorak-mmk