Conversation
havok2063
left a comment
There was a problem hiding this comment.
There is a test that is failing. Can you take a look at it? https://github.com/sdss/tree/actions/runs/14976153785/job/42068909840 It looks like an MWM key error.
| @@ -0,0 +1,9 @@ | |||
| # Guider and FVC image paths | |||
There was a problem hiding this comment.
what is this File.txt? Is this something new?
There was a problem hiding this comment.
The test was the issue, which I just fixed (in principle) because unlike sdsswork which has a top level mwm folder, ipl-3 and dr19 have a top level spectro folder.
I didn't add the test with File.txt, but it isn't real and should be deleted, in my opinion.
There was a problem hiding this comment.
if someone added File.txt, and we don't need, can you delete it?
| ALLSPEC = %(SPECTRO_ROOT)s/allspec | ||
| APOGEE_REDUX = %(SPECTRO_ROOT)s/apogee/redux | ||
| MWM_ASTRA= %(SPECTRO_ROOT)s/astra | ||
| LVM_SPECTRO_REDUX = %(SPECTRO_ROOT)s/lvm/redux |
There was a problem hiding this comment.
Should this go under a new [LVM] section, similar to the [BHM] and [MWM] sections? An example of this is in sdsswork.cfg.
There was a problem hiding this comment.
As in my comment above, there are no top level bhm or mwm or lvm folders (unlike sdsswork), since as of DR18, we now have a top level spectro folder instead, so all of the spectro data products go under [SPECTRO] so the cfg file is as it should be!
| [BHM] | ||
| [general] | ||
| name = ipl-3 | ||
| IPL_ROOT = %(FILESYSTEM)s/%(name)s | ||
| BOSS_SPECTRO_REDUX = %(IPL_ROOT)s/spectro/boss/redux | ||
| SAS_BASE_DIR = %(FILESYSTEM)s | ||
| SAS_ROOT = %(FILESYSTEM)s/%(name)s | ||
|
|
||
| [MWM] | ||
| [DATA] | ||
| name = ipl-3 | ||
| IPL_ROOT = %(FILESYSTEM)s/%(name)s | ||
| MWM_ASTRA= %(IPL_ROOT)s/spectro/astra | ||
| MWM_SSPP= %(IPL_ROOT)s/vac/mwm/sspp | ||
| APOGEE_REDUX = %(IPL_ROOT)s/spectro/apogee/redux |
There was a problem hiding this comment.
why are these sections removed for IPL-3? and why aren't these ini sections included in dr19.cfg
There was a problem hiding this comment.
I don't think anything was removed, since the IPL_ROOT is already defined in ipl1.cfg so it would be inherited in ipl3.cfg. And all of the spectro data products have been moved into
[SPECTRO]
name = ipl-3
SPECTRO_ROOT = %(FILESYSTEM)s/%(name)s/spectro
APOGEE_REDUX = %(SPECTRO_ROOT)s/apogee/redux
BOSS_SPECTRO_REDUX = %(SPECTRO_ROOT)s/boss/redux
LVM_SPECTRO_REDUX = %(SPECTRO_ROOT)s/lvm/redux
MWM_ASTRA = %(SPECTRO_ROOT)s/astra
since they all live under the /spectro top folder (e.g. https://dr19.sdss.org/sas/dr19/spectro), and similarly for the vac data products which have been moved into the [VAC] section since they all live under the /vac top folder (e.g. http://dr19.sdss.org/sas/dr19/vac).
There was a problem hiding this comment.
Note in general, that the set of ini sections in both dr19.cfg and ipl3.cfg should be similar to dr18.cfg and not be based on sdsswork.cfg. i.e. the top level folders in dr19 (and ipl3) are listed at https://dr19.sdss.org/sas/dr19 and include [DATA], [MOS] (no change from dr18.cfg), [SPECTRO] and [VAC] only!
There was a problem hiding this comment.
Ahh I hadn't realized that high level change. Thanks for clarifying!
…-3 and dr19 have a top level spectro folder.
Hi Brian,
The April 15 deadline on VACs is now passed; and even though there were delayed ones, my edits to the ipl3 branch have converged so I'm ready to merge this into main.
Any objections to proceeding with merging the ipl3 branch into main, now?
Thanks,
Joel