Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding apogee paths to dr19#108

Merged
havok2063 merged 4 commits into
mainfrom
dr19apogeefix
May 20, 2025
Merged

Adding apogee paths to dr19#108
havok2063 merged 4 commits into
mainfrom
dr19apogeefix

Conversation

@havok2063

Copy link
Copy Markdown
Collaborator

This PR closes #104 and adds the apogee paths from ipl3 config to dr19 config.

@havok2063 havok2063 requested a review from joelbrownstein May 13, 2025 15:04
@havok2063 havok2063 self-assigned this May 13, 2025
@joelbrownstein

joelbrownstein commented May 13, 2025

Copy link
Copy Markdown
Contributor

Hey Brian,

How did you add the abstract apogee drp paths to dr19.cfg?

There are obvious mistakes such as references to APOGEE_ASPCAP since the dr19 version of the apogee drp does not include aspcap, and the APOGEE_ASPCAP environmental variable does not exist in the dr19.cfg of tree.

You know that I am not one of the apogee drp pipeline developers, so I'm not sure what you're expecting from my review of this PR?

-Joel

@havok2063 havok2063 requested review from ajwheeler and dnidever May 13, 2025 17:33
@havok2063

Copy link
Copy Markdown
Collaborator Author

I just copied them from ipl-3. I added Adam Wheeler and David Nidever to the review. As lead data person, I added you for full completeness and transparency.

@havok2063

Copy link
Copy Markdown
Collaborator Author

@dnidever @ajwheeler @lyx12311 can someone look at the apogee paths for DR19, in the dr19.cfg and fix or remove erroneous paths that are incorrect or shouldn't be there.

@havok2063 havok2063 requested a review from lyx12311 May 13, 2025 17:43
@dnidever

Copy link
Copy Markdown
Contributor

Looks fine to me. We don't need the APOGEE_ASPCAP or APOGEE_TARGET ones anymore, but it shouldn't break anything to have them in there.

@dnidever dnidever closed this May 19, 2025
@havok2063 havok2063 reopened this May 19, 2025
@havok2063 havok2063 merged commit e04dd7f into main May 20, 2025
4 checks passed
@havok2063 havok2063 deleted the dr19apogeefix branch June 3, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apogee paths not in dr19

3 participants