Thanks to visit codestin.com
Credit goes to github.com

Skip to content

allspec for ipl3 and vac cleanup#110

Merged
havok2063 merged 1 commit into
mainfrom
dr19-and-ipl3-updates
Jun 17, 2025
Merged

allspec for ipl3 and vac cleanup#110
havok2063 merged 1 commit into
mainfrom
dr19-and-ipl3-updates

Conversation

@joelbrownstein

Copy link
Copy Markdown
Contributor

Hi @havok2063,

@AMWeijmans is trying to test sdss-access for the allspec file, and I noticed it was added to dr19.cfg already but not ipl3, so I added it, and cleaned up some vac entries.

Would you please have a look at this PR; and do the merge?

In addition, once this PR for tree is merged, could you please tag both tree and sdss-access, which was last done in April, so that https://sdss-access.readthedocs.io/en/latest/paths.html is updated with these latest changes for DR19/IPL3?

Cheers,
Joel

@havok2063

Copy link
Copy Markdown
Collaborator

@joelbrownstein Will do. This made me realize I need to update some of the docs for tree and sdss_access for DR19.

Also, now that Riley has updated the files for the dashboard for DR19, we need to find a final location for these on the SAS, and create a new envvar and/or path. Do you have any suggestions? We'll need to serve everything in this directory, https://data.sdss5.org/sas/sdsswork/users/u6054929/.

@joelbrownstein

Copy link
Copy Markdown
Contributor Author

I moved Riley's sdsswork/users/u6054929 -> https://data.sdss.org/sas/dr19/mos/explorer/
Except I skipped sdsswork/users/u6054929/ipl3, since this appears to be replaced by sdsswork/users/u6054929/dr19; and "may" included leaked data? Let me know if you need that or if its ok to skip it.

@havok2063

Copy link
Copy Markdown
Collaborator

Actually, I realized that we only serve these files via the docker, with Riley's directory mounted inside as a fixed top level explorer datapath envvar. So we don't technically need to release these files. If we release them, then they need datamodels, right? For time's sake, I would say we not release them and leave things as is, but what do you think?

A minimal alternative would be to only release the dr19 files, as you've done, but we don't document them, and we continue to point the dashboard to Riley's user directory. The dashboard expects all releases to be available from the top level datapath.

And yeah, I think the IPL3 files were never updated and do contain the extra data. I think we can safely replace those with the dr19 versions.

@joelbrownstein

Copy link
Copy Markdown
Contributor Author

I suggest we separate the discussion of Riley's users directory from this PR.

So if you don't have any questions on the allspec file's paths or the other changes committed, then would you do the merge and tag tree and sdss_access please?

@havok2063

Copy link
Copy Markdown
Collaborator

Sure but I don't need to tag for the readthedocs to update. The latest docs always point to the latest main. https://sdss-access.readthedocs.io/en/latest/paths.html is already updated. When I tag I want to make sure it has everything we need for DR19.

@havok2063 havok2063 merged commit a14f260 into main Jun 17, 2025
4 checks passed
@havok2063 havok2063 deleted the dr19-and-ipl3-updates branch June 17, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants