LVM paths for dr20#132
Merged
Merged
Conversation
havok2063
reviewed
Apr 20, 2026
|
|
||
| #LVM DRP Paths | ||
| lvm_frame = $LVM_SPECTRO_REDUX/{drpver}/@tilegrp|/{tileid}/{mjd}/lvm{kind}-{expnum:0>8}.fits | ||
| lvm_sframe = $LVM_SPECTRO_REDUX/{drpver}/@tilegrp|/{tileid}/{mjd}/lvmSFrame-{expnum:0>8}.fits |
Collaborator
There was a problem hiding this comment.
@joelbrownstein I saw you merged this already. that's fine. You technically don't need the lvm_sframe separate path. lvm_frame is the correct path with kind='SFrame'. This allows users to also access any of the other frame files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's 1 path (for the QA summary file) still pending, but these DAP and DRP paths are ready now.