IPL-4#81
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 84.52% 84.52%
=======================================
Files 3 3
Lines 614 614
Branches 143 143
=======================================
Hits 519 519
Misses 57 57
Partials 38 38 ☔ View full report in Codecov by Sentry. |
havok2063
approved these changes
Feb 20, 2024
havok2063
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @havok2063 Can you check that I added a stub for IPL-4 to tree correctly, with no changes expected from IPL-3 (either env vars or paths), since IPL-4 has the same structure as IPL-3 except more data including additional MJDs after summer shutdown, and data from LCO -- neither of which are included in the IPL-3 DR19 candidate. Details available at http://wiki.sdss.org/display/IPL/IPL-4