Conversation
|
This looks great to me! If Brian has no further comments, since he is on review, I will proceed with the merge and update at Utah tomorrow am. |
havok2063
left a comment
There was a problem hiding this comment.
I have some comments and some requested changes.
|
|
||
| [PATHS] | ||
| # no changes from IPL-3 | ||
| sdR_S = $BOSS_SPECTRO_DATA_S/{obs}/{mjd}/sdR-{br}{id}-{frame}.fit |
There was a problem hiding this comment.
Do we need an ipl-4.cfg file at all, since there will be no IPL-4? I would prefer to remove this file if we will never be releasing anything from it. It will also avoid confusion from people if they see it as an option in tree/sdss_access.
There was a problem hiding this comment.
I will happily delete it, I just wanted to make sure that if it is there it is correct.
There was a problem hiding this comment.
I have no objections to deleting ipl4.cfg! IPL-4 was never announced, and is no longer maintained; and may be deleted from the SAS to recover disk space (to be discussed on a future data call).
| spAll_epoch = $BOSS_SPECTRO_REDUX/{run2d}/spAll-{run2d}.fits | ||
| spAllLine_epoch = $BOSS_SPECTRO_REDUX/{run2d}/spAllLine-{run2d}.fits | ||
| spCFrame_epoch = $BOSS_SPECTRO_REDUX/{run2d}/@pad_fieldid|@isplate|/spFrame-{br}{id}-{frame:0>8}.fits.gz | ||
| SciExp = $BOSS_SPECTRO_REDUX/{run2d}/@pad_fieldid|@isplate|/SciExp-@pad_fieldid|.par |
There was a problem hiding this comment.
can you either make this camelCase sciExp or snake_case, sci_exp? Same across all configs.
There was a problem hiding this comment.
I have no objections and will do this on Monday. I had been matching the paths as close as possible to the file names, but will adjust them to camelCase.
havok2063
left a comment
There was a problem hiding this comment.
Looks good to me now.
Added missing BOSS DRP paths, fixed errors in existing paths, and added the LCO BOSS (sdR) raw data path