Update dr19.cfg#98
Merged
Merged
Conversation
Defines DATA_ROOT and MWM_ASTRA
Contributor
|
I believe the DATA_ROOT does not need to be added, since it is inherited from the dr18.cfg. Conversely, MWM_ASTRA was not defined in dr18.cfg (since it was not released yet), so does need to be added! I'll take a turn editing dr19.cfg |
Contributor
|
Hi Brian, Can you check the lastest commit to dr19.cfg is OK; and merge the PR if you think it is ready? |
Collaborator
|
This seems fine to me. As a reminder, when we inherit from a previous config, we only need to define, or re-define, environment variables, or paths, if they are new or have changed from the previous config. |
havok2063
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines
DATA_ROOTandMWM_ASTRA.In generating the dms for dr19, I'm running into
I think this addresses that?