mcs: refactor finaliseCap to ease verification #1474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This in particular introduces the function schedContext_unbindReply, which is used within finaliseCap, as well as invokeSchedContext_Unbind. Signed-off-by: Michael McInerney <[email protected]>
Contributor
Author
|
Since this updates |
Indanz
approved these changes
Jun 4, 2025
| void schedContextMaybeUnbindNtfn(notification_t *ntfnPtr) | ||
| { | ||
| sched_context_t *boundSchedContext; | ||
| boundSchedContext = (sched_context_t *)notification_ptr_get_ntfnSchedContext(ntfnPtr); |
Contributor
There was a problem hiding this comment.
Any reason why SC_PTR isn't used here?
And I'd prefer sc or boundSC, which would shorten the line perhaps enough to fit it on one line.
Contributor
Author
There was a problem hiding this comment.
No reason. I might have just copied this style from somewhere else. Maybe I'll go with
sched_context_t *sc = SC_PTR(notification_ptr_get_ntfnSchedContext(ntfn));
This lines occurs exactly in maybeReturnSchedContext, actually, so I guess we have prior art
Member
There was a problem hiding this comment.
We should prefer the macro (SC_PTR) when we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This in particular introduces the function
schedContext_unbindReply, which is used within
finaliseCap, as well as invokeSchedContext_Unbind.