optimize : reorganize the usage of task session manager(add/remove/find/update) #4858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #4858 +/- ##
============================================
- Coverage 48.78% 48.73% -0.06%
+ Complexity 4164 4157 -7
============================================
Files 743 743
Lines 26588 26577 -11
Branches 3320 3320
============================================
- Hits 12970 12951 -19
- Misses 12220 12229 +9
+ Partials 1398 1397 -1
|
1 task
Contributor
|
sessionMnager改造终态分4步 |
|
|
funky-eyes
reviewed
Jan 30, 2023
server/src/main/java/io/seata/server/session/SessionHolder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/session/SessionHolder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/session/SessionHolder.java
Outdated
Show resolved
Hide resolved
1 task
Contributor
Author
|
pr做的不够干净，关联一下后续 #5604 |
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
重新整理SessionHolder里面的几个sessionManager，统一把对globalsession的增删查改都改为使用root manager。
现在还没正式改好代码，我把需要改的地方全部todo标注出来，后面改的时候每改一个就删一个todo注释。以下是梳理情况：
查询（把有非root的地方改成root.findxx ,真正要改的地方只有3个,已经用红色圈出来）
allsessions本来在不同的manager有自带不同的查询条件，但现在看起来已经被改造过了
删除（把有非root的地方改成root.removexx ,真正要改的地方只有4个,已经用红色圈出来）
更新（实际上只有changeStatus调用，但用到这个的地方很多，经过讨论决定把listener逻辑从manager摘出去）
新增（分两种情况，1是真正的新增，改成root.addxx ，2其实是更新，改成root.updatexx，具体属于1还是2可以看代码todo标识）
Ⅱ. Does this pull request fix one issue?
部分解决 #4857
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews