optimize : reorganize the usage of Sessionmanager and SessionLifecycleListener #4881

Bughue · 2022-08-23T03:47:53Z

I have registered the PR changes.

Ⅰ. Describe what this PR did

在https://github.com/seata/seata/issues/4857的问题里，分两个pr解决

简单的把外部用到非rootmanager的地方改造回同语义的rootmanager方法 optimize : reorganize the usage of task session manager(add/remove/find/update) #4858
这个pr把listener从sessionmanager剥离，并进行同语义的改造

这个pr做了以下几件事

AbstractSessionManager不再实现SessionLifecycleListener
去掉所有session.addlistener的操作（因为现在已经没有类属于SessionLifecycleListener）
SessionManager不再继承SessionLifecycleListener，SessionManager里面定义和SessionLifecycleListener同名的方法（用于处理主流程），这样AbstractSessionManager里面的方法实现无需改动，但调用方需要整改（并删掉getRetryRollbackingSessionManager()和getRetryCommittingSessionManager()）
GlobalSession作为调用方，在所有遍历lifecycleListeners之前，优先调用SessionHolder.getRootSessionManager()的同名方法进行主逻辑处理
AbstractSessionManager的updateGlobalSessionStatus方法要进行set status
单测整改（涉及sessionholder的地方要初始化，xid缺失的地方要补充）

这个pr把addlistener的操作已经全部去掉，但这个方法和listener自身机制保留（目前闲置），以后有必要再使用
由于现在SessionLifecycleListener只有被GlobalSession调用，所以只需要改好GlobalSession就可以

上图是用临时改方法名的方法用错误统计来显示全部的调用

Ⅱ. Does this pull request fix one issue?

fixes #4857

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-commenter · 2022-08-24T08:22:48Z

Codecov Report

Merging #4881 (0feda8b) into 2.x (4b724e2) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #4881      +/-   ##
============================================
- Coverage     48.51%   48.40%   -0.11%     
+ Complexity     4188     4167      -21     
============================================
  Files           764      764              
  Lines         26924    26892      -32     
  Branches       3348     3348              
============================================
- Hits          13061    13016      -45     
- Misses        12475    12479       +4     
- Partials       1388     1397       +9

Impacted Files	Coverage Δ
...java/io/seata/server/coordinator/AbstractCore.java	`54.02% <ø> (-1.04%)`	⬇️
.../java/io/seata/server/coordinator/DefaultCore.java	`47.59% <ø> (-0.65%)`	⬇️
...in/java/io/seata/server/session/SessionHolder.java	`60.18% <ø> (-1.24%)`	⬇️
...o/seata/server/coordinator/DefaultCoordinator.java	`44.89% <100.00%> (-2.12%)`	⬇️
...o/seata/server/session/AbstractSessionManager.java	`62.31% <100.00%> (+0.55%)`	⬆️
...in/java/io/seata/server/session/GlobalSession.java	`69.92% <100.00%> (-10.61%)`	⬇️
...ver/storage/db/session/DataBaseSessionManager.java	`41.17% <100.00%> (+4.33%)`	⬆️
...rage/redis/store/RedisTransactionStoreManager.java	`74.67% <0.00%> (-0.79%)`	⬇️
... and 4 more

…ager_x_listener

…into dev_session_manager_x_listener

…ager_x_listener � Conflicts: � server/src/main/java/io/seata/server/coordinator/DefaultCore.java

CLAassistant · 2022-12-12T13:15:18Z

All committers have signed the CLA.

…ager_x_listener � Conflicts: � server/src/main/java/io/seata/server/session/GlobalSession.java

…_x_listener � Conflicts: � server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java � server/src/main/java/io/seata/server/session/SessionHolder.java

server/src/main/java/io/seata/server/session/GlobalSession.java

server/src/main/java/io/seata/server/session/SessionManager.java

funky-eyes

LGTM

…eListener (apache#4881)

Bughue and others added 6 commits August 22, 2022 19:12

remove addlistener

a19215d

Strip listener from sessionmanager

b62770a

Merge branch 'develop' into dev_session_manager_x_listener

e29c405

session.setStatus in AbstractSessionManager

2753979

session.setStatus in AbstractSessionManager

db81dc5

fix test

29ac34f

Bughue changed the title ~~[WIP] optimize : reorganize the usage of task session manager(separate listener and manager)~~ optimize : reorganize the usage of task session manager(separate listener and manager) Aug 24, 2022

Bughue mentioned this pull request Aug 26, 2022

[WIP]optimize : change transaction state thread-safe in db mode #4383

Closed

Bughue changed the title ~~optimize : reorganize the usage of task session manager(separate listener and manager)~~ [WIP]optimize : reorganize the usage of task session manager(separate listener and manager) Aug 29, 2022

slievrly added the TC/store store mode label Sep 7, 2022

Bughue and others added 6 commits September 9, 2022 16:38

ignore taskname in allsessions

57cf116

Merge branch 'develop' of github.com:seata/seata into dev_session_man…

654fe63

…ager_x_listener

Merge branch 'develop' into dev_session_manager_x_listener

62d7ba1

check-style

284c3e9

Merge remote-tracking branch 'origin/dev_session_manager_x_listener' …

b56d40f

…into dev_session_manager_x_listener

check-style

d4f8a4a

This was referenced Oct 27, 2022

optimize : reorganize the usage of task session manager(add/remove/find/update) #4858

Merged

task session manager chaos #4857

Closed

Bughue added 2 commits December 12, 2022 17:31

Merge branch 'develop' of github.com:seata/seata into dev_session_man…

b9a76f4

…ager_x_listener � Conflicts: � server/src/main/java/io/seata/server/coordinator/DefaultCore.java

fix test

f84e59a

Bughue and others added 3 commits January 17, 2023 18:15

Merge branch 'develop' into dev_session_manager_x_listener

0fc58c2

Merge branch 'develop' of github.com:seata/seata into dev_session_man…

caf4e09

…ager_x_listener � Conflicts: � server/src/main/java/io/seata/server/session/GlobalSession.java

Merge branch '2.x' of github.com:seata/seata into dev_session_manager…

3679553

…_x_listener � Conflicts: � server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java � server/src/main/java/io/seata/server/session/SessionHolder.java

Bughue changed the title ~~[WIP]optimize : reorganize the usage of task session manager(separate listener and manager)~~ optimize : reorganize the usage of task session manager(separate listener and manager) Jan 31, 2023

changestatus & remove queueToAsyncCommitting

5dbb83e

Bughue changed the base branch from develop to 2.x January 31, 2023 09:19

funky-eyes added module/server server module type: optimize labels Jan 31, 2023

funky-eyes added this to the 2.0.0 milestone Jan 31, 2023

funky-eyes reviewed Jan 31, 2023

View reviewed changes

server/src/main/java/io/seata/server/session/GlobalSession.java Outdated Show resolved Hide resolved

server/src/main/java/io/seata/server/session/SessionManager.java Show resolved Hide resolved

Bughue added 2 commits January 31, 2023 18:55

过渡期方法标记废弃

fa590d9

branchSession.setStatus(status);

80a4d3b

funky-eyes approved these changes Feb 1, 2023

View reviewed changes

Bughue changed the title ~~optimize : reorganize the usage of task session manager(separate listener and manager)~~ optimize : reorganize the usage of Sessionmanager and listener Feb 1, 2023

Bughue changed the title ~~optimize : reorganize the usage of Sessionmanager and listener~~ optimize : reorganize the usage of Sessionmanager and SessionLifecycleListener Feb 1, 2023

changes

0feda8b

funky-eyes merged commit 25999c3 into apache:2.x Feb 1, 2023

Bughue mentioned this pull request Apr 10, 2023

optimize : change transaction state thread-safe in db mode #5501

Merged

YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025

optimize : reorganize the usage of Sessionmanager and SessionLifecycl…

cbf2643

…eListener (apache#4881)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

optimize : reorganize the usage of Sessionmanager and SessionLifecycleListener #4881

optimize : reorganize the usage of Sessionmanager and SessionLifecycleListener #4881

Uh oh!

Bughue commented Aug 23, 2022 •

edited

Loading

Uh oh!

codecov-commenter commented Aug 24, 2022 •

edited

Loading

Uh oh!

CLAassistant commented Dec 12, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

funky-eyes left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

optimize : reorganize the usage of Sessionmanager and SessionLifecycleListener #4881

optimize : reorganize the usage of Sessionmanager and SessionLifecycleListener #4881

Uh oh!

Conversation

Bughue commented Aug 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

codecov-commenter commented Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

CLAassistant commented Dec 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

funky-eyes left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Bughue commented Aug 23, 2022 •

edited

Loading

codecov-commenter commented Aug 24, 2022 •

edited

Loading

CLAassistant commented Dec 12, 2022 •

edited

Loading