feature: add jackson json parser and gson json parser for tcc business action context #5352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Feb 17, 2023
integration-tx-api/src/main/java/io/seata/integration/tx/api/util/JsonUtil.java
Show resolved
Hide resolved
| */ | ||
| public class JsonParserFactory { | ||
|
|
||
| private static Map<String, JsonParser> JSON_PARSER_INSTANCES = new ConcurrentHashMap<>(); |
integration-tx-api/src/main/java/io/seata/integration/tx/api/json/JsonParserFactory.java
Outdated
Show resolved
Hide resolved
integration-tx-api/src/main/java/io/seata/integration/tx/api/util/JsonUtil.java
Outdated
Show resolved
Hide resolved
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #5352 +/- ##
============================================
+ Coverage 48.54% 48.73% +0.19%
- Complexity 4300 4311 +11
============================================
Files 771 775 +4
Lines 27350 27372 +22
Branches 3410 3408 -2
============================================
+ Hits 13277 13340 +63
+ Misses 12669 12627 -42
- Partials 1404 1405 +1
|
| return this.mapper.writeValueAsString(object); | ||
| } catch (JsonProcessingException e) { | ||
| LOGGER.error("jackson toJSONString exception, {}", e.getMessage(), e); | ||
| throw new RuntimeException(e); |
Contributor
There was a problem hiding this comment.
- 异常抛出了，就不要在日志里记录堆栈。会导致重复记录；
- 另外，单独加一个JSON解析异常类吧。多种JSON解析方式失败后，都抛出同一种异常。
l81893521
reviewed
Feb 17, 2023
| if (Objects.isNull(text) || Objects.isNull(clazz)) { | ||
| return null; | ||
| } | ||
| String jsonParseName; |
Contributor
There was a problem hiding this comment.
Here has a bug and may change to
String jsonParseName = text.startsWith(Constants.JACKSON_JSON_TEXT_PREFIX) ?
Constants.JACKSON_JSON_PARSER_NAME : CONFIG_JSON_PARSER_NAME;
slievrly
reviewed
Feb 17, 2023
Member
Support for Spring configuration is currently environment first, but should existing PropertiesBeans be consistent? |
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
…s action context (apache#5352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5011
fixes #5334
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews