Add value type information to InvalidArgumentException#699
Merged
Conversation
This would be slightly more useful when debugging certain issues, I could've identified the issue quicker if I was presented with this extra information.
sebastianbergmann
added a commit
that referenced
this pull request
Oct 24, 2012
Owner
|
Thanks! Can you send a pull request for http://github.com/sebastianbergmann/php-code-coverage/blob/master/PHP/CodeCoverage/Util/InvalidArgumentHelper.php as well? |
edorian
added a commit
that referenced
this pull request
Nov 10, 2012
edorian
added a commit
to sebastianbergmann/php-code-coverage
that referenced
this pull request
Nov 10, 2012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would be slightly more useful when debugging certain issues, I could've identified unexpected issues easier if I was presented with this extra information.
The new exception message would look similar to this:
Argument #1 (valueType#value) of class::function() must be a type.
Or
Argument #1 (No Value) of class::function() must be a type.