Fixed Scan not marked as Errored when exceeding the Job BackoffLimit #2568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d due to exceeding the backoff limit we had the assumption that job.Status.Failed calculates the number of times the job failed. it is actually the number of pods that failed due to this job. In this case it will always be a max of 1. Supplemented it with job.Status.Conditions[].Reason Signed-off-by: Ilyes Ben Dlala <[email protected]>
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| golangci-lint | yes | 1 | 0.42s |
See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by
J12934
reviewed
Jul 18, 2024
Signed-off-by: Ilyes Ben Dlala <[email protected]>
|
Weltraumschaf
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add isBackoffLimitExceeded function to check if a job has failed due to exceeding the backoff limit
we had the assumption that job.Status.Failed calculates the number of times the job failed. it is actually the number of pods that failed due to this job. In this case it will always be a max of 1.
Supplemented it with job.Status.Conditions[].Reason
closes #2326
Checklist