Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add podSecurityContext to zap-scan-type template #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2024
Merged

Add podSecurityContext to zap-scan-type template #2576

merged 2 commits into from
Jul 18, 2024

Conversation

eliihen
Copy link
Contributor

@eliihen eliihen commented Jul 17, 2024

Description

The field scanner.podSecurityContext is documented as being supported by zap-automation-framework, but is not actually added to the template. This change adds it to the template so it is actually put onto the job when run.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@netlify Netlify
Copy link

netlify bot commented Jul 17, 2024 •
edited
Loading

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 810813d
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/6698b0d3554a470008efb09e

@Weltraumschaf Weltraumschaf added enhancement New feature or request scanner Implement or update a security scanner labels Jul 17, 2024
@Weltraumschaf
Copy link
Member

Weltraumschaf commented Jul 17, 2024 •
edited
Loading

Hi @eliihen,

thanks for submitting this issue. We'll investigate this.

Ah, upsi. It is a PR not an issue 😬 Thank you for contribution 🙌

J12934
J12934 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch.
Thank you for the fix 🙌

@J12934 J12934 merged commit 38c052e into secureCodeBox:main Jul 18, 2024
52 checks passed
@eliihen eliihen deleted the patch-1 branch July 18, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J12934 J12934 J12934 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request scanner Implement or update a security scanner
Projects
secureCodeBox v4
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliihen @Weltraumschaf @J12934