Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix nodeSelectors not working properly #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2024
Merged

Fix nodeSelectors not working properly #2582

merged 3 commits into from
Jul 19, 2024

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Jul 18, 2024

Description

  • Fixes incorrect type used in our CRDs for the node selector. Confusingly NodeSelector is NOT used for NodeSelectors in Kubernetes... The corev1.NodeSelector type is used for node affinities primarily. Super weird and confusing.
  • This changes the crds, and needs our usual CRD changed warning in the release. As the fields changed have never worked prior to this fix I don't consider this to be breaking.
  • Propery merge in node selectors from scan and parse/hook into the started jobs

Closes #2328

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

J12934 added 2 commits July 18, 2024 16:47
@J12934
secureCodeBox#2328 Fix incorrect type used for NodeSelector
18481f4 
Confusingly NodeSelector is NOT used for NodeSelectors in Kubernetes...
The corev1.NodeSelector type is used for node affinities primarily. Super weird and confusing.

Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
secureCodeBox#2328 Propery merge in node selectors from scan and pars…
a7e68e5 
…e/hook into the started jobs

Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934 J12934 added bug Bugs CRD Improvements or additions to CRDs labels Jul 18, 2024
@J12934 J12934 self-assigned this Jul 18, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 18, 2024 •
edited
Loading

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 4675e41
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/66995691af6f6a0008afd014

@J12934 J12934 merged commit 67152e0 into secureCodeBox:main Jul 19, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weltraumschaf Weltraumschaf Weltraumschaf approved these changes

Assignees

@J12934 J12934

Labels
bug Bugs CRD Improvements or additions to CRDs
Projects
secureCodeBox v4
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NodeSelector configuration not working as documented in SecureCodeBox v4.4.0
2 participants
@J12934 @Weltraumschaf