Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support setting env variables for Scans generated by the Kubernetes AutoDiscovery #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Aug 23, 2024

Description

This allows to set the env vars on the Scan.
This can be helpful when you want to configure some part of the scan via the environment vars.
In particular I'd like to have this so that i can use the zap-automation-framework with a generic config and overwrite the target based on the service discovered by the auto-discovery.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@J12934 J12934 added enhancement New feature or request auto-discovery labels Aug 23, 2024
@J12934 J12934 self-assigned this Aug 23, 2024
Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 04e2f9a
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/66c85d84f05cac0008336113

Copy link

Copy link
Contributor

@Reet00 Reet00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Test is also fine

@J12934 J12934 merged commit a974b89 into secureCodeBox:main Aug 27, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-discovery enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants