Add a optional ttlSecondsAfterFinished field to scans to cleanup finished scans #2293 #2631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-securecodebox canceled.
|
J12934
requested changes
Aug 27, 2024
…tomatic removal of scans Signed-off-by: Samreet Singh <[email protected]>
Needed to record the completion time of the scan in order to automatically delete a scan Signed-off-by: Samreet Singh <[email protected]>
…d be deleted automatically Signed-off-by: Samreet Singh <[email protected]>
6437d1d to
aabce59
Compare
…was set checkIfTTLSecondsAfterFinishedisCompleted checks if the option was set and if the time has exceeded Signed-off-by: Samreet Singh <[email protected]>
Signed-off-by: Samreet Singh <[email protected]>
…ed scans to be able to use this to determine the deletion time for errored scans Signed-off-by: Samreet Singh <[email protected]>
Signed-off-by: Samreet Singh <[email protected]>
Signed-off-by: Samreet Singh <[email protected]> Co-authored-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Samreet Singh <[email protected]> Co-authored-by: Jannik Hollenbach <[email protected]>
a3b8294 to
1b8c201
Compare
|
J12934
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ttlSecondsAfterFinished option to automatically delte finished and errored scans after a defined time in seconds. This will delete the specific scan and not just a scanner/parser job.
Also sets the finishedAt attribute to the timestamp a scan is marked as "Done" or "Errored".
Checklist