Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add env for istio sidecar injection annotation closes #2652 #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Michael-Kruggel
Copy link
Contributor

@Michael-Kruggel Michael-Kruggel commented Sep 18, 2024

Signed-off-by: Jannik Hollenbach [email protected]
Signed-off-by: Michael-Kruggel [email protected]<!--
Thank you for your contribution to our Project πŸ™Œ

Before submitting your Pull Request, please take the time to check the points below and provide some descriptive information.

  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a meaningful title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes Cannot save advanced scan parametersΒ #41)
  • Link your Pull Request to an issue (if applicable)
  • Create Draft pull requests if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure each new source file you add has a correct license header.

For more information on content related and formal acceptance criteria for PRs, please have a look at our
docs.
-->

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Copy link

netlify bot commented Sep 18, 2024

βœ… Deploy Preview for docs-securecodebox canceled.

Name Link
πŸ”¨ Latest commit 7ab8c93
πŸ” Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/66ebd9b9f840a200081d04ad

@Michael-Kruggel Michael-Kruggel changed the title Add env for istio sidecar injection annotation Add env for istio sidecar injection annotation closes #2652 Sep 18, 2024
@Michael-Kruggel Michael-Kruggel force-pushed the configurable-istio-annotation branch from d21bde5 to ce11b20 Compare September 18, 2024 19:23
@Michael-Kruggel
Copy link
Contributor Author

Not sure what happened with the fork and the extra commits, but if its a problem I can redo it.

@Michael-Kruggel
Copy link
Contributor Author

Also not sure whats going on with the Run sbctcl Tests. I ran it locally and it passed.

Would potentially be confusing otherwise as the operator doesn't inject the istio sidecars, it's just allowing/preventing it.

Signed-off-by: Jannik Hollenbach <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required β‰₯ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@J12934
Copy link
Member

J12934 commented Sep 19, 2024

Awesome πŸ™Œ
I've renamed it slightly to prevent potential confusion, will merge once the pipeline is passing.

(the scbctl test have started randomly failing in the pipeline since last week. very unlikely that this has to do anything with it.)

@J12934 J12934 merged commit 122c740 into secureCodeBox:main Sep 19, 2024
53 of 54 checks passed
@ddddddO ddddddO mentioned this pull request Sep 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cannot save advanced scan parameters
2 participants