Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Issue MS Teams Notification Hook Not Being Able To Deliver Messages #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 20, 2024
Merged

Fix Issue MS Teams Notification Hook Not Being Able To Deliver Messages #2666

merged 7 commits into from
Sep 20, 2024

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Sep 19, 2024 •
edited
Loading

Description

This PR fixes a issue with notifications not beeing properly delivered to MS Teams by setting the content type for the http request send to MS Teams.

Closes #2664

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@J12934
Remove unused import
340c66c 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Change prettier config to only have the bracketSpacing set for yaml f…
2e68005 
…iles

We set it specifically for yaml and don't want it in other languages

Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Auto format with prettier
3f033b5 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Exclude prettier reformatting from git blames
a3c1f2f 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Fix deprecated jest methods in tests
6214c3b 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Send requests to MS Teams with "application/json" content type
4425add 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Replace test urls with example.com ones to prevent clashes with acuta…
1bae124 
…lly registerable domains

Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934 J12934 added the bug Bugs label Sep 19, 2024
@J12934 J12934 self-assigned this Sep 19, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 1bae124
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/66ebe495b6238d0008b1af5b

@J12934 J12934 merged commit 2a80c31 into secureCodeBox:main Sep 20, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ilyesbdlala Ilyesbdlala Ilyesbdlala approved these changes

Assignees

@J12934 J12934

Labels
bug Bugs
Projects
secureCodeBox v4
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using MS Teams as notification channel with new Workflows results in 400 Bad Request
2 participants
@J12934 @Ilyesbdlala