Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Nov 22, 2024

Description

Encountered an issue while using kueue, which considers duplicate env vars to be a error in the job definition, even though kubernetes can handle it (this is why we haven't noticed it yet)

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

This should ensure that the func doesn't crash when it empty

Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934 J12934 added the bug Bugs label Nov 22, 2024
@J12934 J12934 requested a review from Ilyesbdlala November 22, 2024 15:39
@J12934 J12934 self-assigned this Nov 22, 2024
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 9284f38
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/6740a6b72437cb000848b98d

Signed-off-by: Jannik Hollenbach <[email protected]>
Copy link

Copy link
Member

@Ilyesbdlala Ilyesbdlala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, actual TDD in the wild.
LGTM

@Ilyesbdlala Ilyesbdlala merged commit fe9df2c into secureCodeBox:main Dec 3, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants