Fix http-webhook chart #2878
Merged
Fix http-webhook chart #2878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven Schliesing <[email protected]>
serviceName and servicePort were removed and pathType is required in 1.22: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122 Signed-off-by: Sven Schliesing <[email protected]>
Otherwise it would break the yaml: --- # SPDX-License-Identifier: Apache-2.0apiVersion: networking.k8s.io/v1 kind: Ingress --- Signed-off-by: Sven Schliesing <[email protected]>
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Jannik Hollenbach <[email protected]>
|
J12934
approved these changes
Feb 6, 2025
|
Perfect :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the helm chart for "http-webhook". It's removing support for older Kubernetes versions (pre 1.22) ruthlessly but supporting those would bloat the template and feels unnecessary.
Checklist