Rename ClusterRole and ClusterRoleBinding #3002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request includes breaking changes. Please make sure that you included the breaking changes and the steps required to upgrade in Upgrading. |
3abe5ed to
1de62fe
Compare
Rename the ClusterRole 'manager-role' and ClusterRoleBinding 'manager-rolebinding' to 'securecodebox-manager-role' and 'securecodebox-manager-rolebinding', respectively, because the original names are too generic and could collide with other projects in the same cluster. Signed-off-by: Boris Shek <[email protected]>
1de62fe to
632942e
Compare
…g in upgrading.md Add a "From 4.X to 5.X" section in upgrading.md. Add an explanation that the operator’s ClusterRole 'manager-role' and ClusterRoleBinding 'manager-rolebinding' have been renamed to 'securecodebox-manager-role' and 'securecodebox-manager-rolebinding'. Signed-off-by: Boris Shek <[email protected]>
|
|
Resolves #2621 |
|
looks good :) |
J12934
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the ClusterRole 'manager-role' and ClusterRoleBinding 'manager-rolebinding' to 'securecodebox-manager-role' and 'securecodebox-manager-rolebinding', respectively, because the original names are too generic and could collide with other projects in the same cluster.
Description
Checklist