Normalization for GA4 custom event name #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to leave this as a draft PR until I deploy & test in staging, and until after change freeze ends on Tuesday |
brennan
reviewed
Dec 30, 2021
packages/destination-actions/src/destinations/google-analytics-4/customEvent/index.ts
Outdated
Show resolved
Hide resolved
brennan
reviewed
Dec 30, 2021
packages/destination-actions/src/destinations/google-analytics-4/customEvent/index.ts
Outdated
Show resolved
Hide resolved
nick-Ag
commented
Jan 4, 2022
| import { client_id } from '../ga4-properties' | ||
|
|
||
| const normalize_event_name = (name: string, lowercase: boolean | undefined): string => { | ||
| name = name.trim() |
There was a problem hiding this comment.
Trim so we can avoid outputting something like: ___Event_Name__
nick-Ag
commented
Jan 4, 2022
packages/destination-actions/src/destinations/google-analytics-4/customEvent/index.ts
Outdated
Show resolved
Hide resolved
kdaswani
reviewed
Jan 4, 2022
packages/destination-actions/src/destinations/google-analytics-4/customEvent/index.ts
Outdated
Show resolved
Hide resolved
|
@nick-Ag Can we update the Event Name description in the Custom Event action to say something like this? |
brennan
reviewed
Jan 5, 2022
| import type { Payload } from './generated-types' | ||
| import { client_id } from '../ga4-properties' | ||
|
|
||
| const normalize_event_name = (name: string, lowercase: boolean | undefined): string => { |
There was a problem hiding this comment.
Nit, camelCase would be convention for function names, but not a blocker.
brennan
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since custom events sent to google cannot include spaces in the event name, this removes spaces before sending and introduces a toggle for users to convert the event name to lowercase.
Testing
Tested in staging and all looks good:
