fix decoding lists of TRUE values #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2022 10:32
achille-roussel
commented
Apr 26, 2022
Comment on lines
+433
to
+438
| i *= 64 | ||
| for (mask & 1) != 0 { | ||
| mask >>= 1 | ||
| i++ | ||
| } | ||
| field := &dec.fields[i] |
There was a problem hiding this comment.
This is a fix for another bug: the error was reporting the wrong field ID.
There was a problem hiding this comment.
Worth amending the commit or nah
There was a problem hiding this comment.
I think we're fine, this code is going to live on Github "forever", the context is here.
kevinburkesegment
approved these changes
Apr 26, 2022
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for an undocumented edge case in the thrift protocol where collections of boolean values that are all
trueare sometimes encoded with theTRUEtype instead ofBOOL.