go 1.17 + build with github actions #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriso
approved these changes
Sep 28, 2021
added 8 commits
September 27, 2021 22:44
Merged
pelletier
reviewed
Sep 28, 2021
| go-version: 1.17 | ||
|
|
||
| - name: Setup Benchstat | ||
| run: go install golang.org/x/perf/cmd/benchstat@latest |
There was a problem hiding this comment.
@achille-roussel I'm curious to see in practice how consistent results are when running benchmarks on multi-tenant GitHub Actions runners. I've seen it vary quite wildly.
There was a problem hiding this comment.
Yeah, it looks like the results are a bit random, probably depends on the VM that the task lands on. This is mostly interesting to showcase how to automate this workflow.
I think we'll need to use self-hosted runners on hosts that are designed to run benchmarks of this kind if we wanted to get more meaningful results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables some optimizations for Go 1.17, and moves the projects to use Github actions.