Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow dimensions in SelectMenu to be strings #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2019
Merged

Allow dimensions in SelectMenu to be strings #579

merged 1 commit into from
Jun 11, 2019

Conversation

dy
Copy link
Contributor

@dy dy commented Jun 10, 2019

Stringy height="100%" works perfectly, cept it logs an error in console.
This should fix it.
@mshwery

mshwery
mshwery approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@mshwery mshwery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks 🔥

@mshwery mshwery merged commit df5bc46 into segmentio:master Jun 11, 2019
robphoenix added a commit to robphoenix/evergreen that referenced this pull request Jul 11, 2019
@robphoenix
Allow string props in SelectMenuContent dimensions
5e3c2d4 
This follows on from segmentio#579
@robphoenix robphoenix mentioned this pull request Jul 11, 2019
Merged
mshwery pushed a commit that referenced this pull request Jul 11, 2019
@robphoenix
Allow string props in SelectMenuContent dimensions (#594)
5f7021e 
This follows on from #579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mshwery mshwery mshwery approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dy @mshwery