Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BigQuery content edits #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 9, 2021
Merged

BigQuery content edits #2248

merged 6 commits into from
Dec 9, 2021

Conversation

forstisabella
Copy link
Contributor

Proposed changes

Grammar/Vale-related edits to the BigQuery storage destination page

Merge timing

No rush!

Related issues (optional)

N/A

@forstisabella forstisabella added the fixed-content fix to content that has outdated or wrong information label Dec 3, 2021
@forstisabella forstisabella requested a review from a team as a code owner December 3, 2021 20:28
@forstisabella forstisabella requested review from markzegarelli and removed request for a team December 3, 2021 20:28
markzegarelli
markzegarelli suggested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@markzegarelli markzegarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes / comments.

I noticed that this lines in this article are very strange, with returns inserted in many places where they don't need to be. I called it out in a few comments, but it really applies to the whole article.

@forstisabella forstisabella merged commit 57abd0e into develop Dec 9, 2021
@forstisabella forstisabella deleted the bigquery-storage-updates branch December 9, 2021 17:00
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@markzegarelli markzegarelli markzegarelli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forstisabella @markzegarelli