Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Friendbuy browser destination #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dhull
Copy link
Contributor

@dhull dhull commented Dec 7, 2021

Proposed changes

Added documentation for Friendbuy browser destination

Merge timing

ASAP once approved

@dhull dhull requested a review from a team as a code owner December 7, 2021 17:26
@dhull dhull requested review from rchinn1 and removed request for a team December 7, 2021 17:26
@markzegarelli markzegarelli self-requested a review December 8, 2021 18:37
@markzegarelli
Copy link
Contributor

Hi @dhull, thanks for the contribution!

We'd like to make a few additional edits, but don't have write access to your fork. Can you check the Allow edits from maintainers setting on the Pull Request, as described here?

@dhull
Copy link
Contributor Author

dhull commented Dec 8, 2021

@markzegarelli Hmm, I don't see an "Allow edits from maintainers" checkbox
Screen Shot 2021-12-08 at 1 41 32 PM
.

I believe that might be because the segment-docs fork that is the source of the PR is owned by the friendbuy organization instead of by me.

@markzegarelli
Copy link
Contributor

@dhull Thanks for checking. What we might do then is merge this into an intermediate branch in our repo, then make the adjustments there. We'll tag you in that PR just so you can have eyes on as well.

@markzegarelli markzegarelli changed the base branch from develop to Friendbuy-destination December 9, 2021 18:16
@markzegarelli markzegarelli merged commit 20a7d72 into segmentio:Friendbuy-destination Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants