Add clarity to Events in Sendgrid source and fix a typo #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de2908a to
187a983
Compare
stayseesong
reviewed
Dec 8, 2021
Co-authored-by: stayseesong <[email protected]>
stayseesong
reviewed
Dec 8, 2021
stayseesong
reviewed
Dec 8, 2021
stayseesong
reviewed
Dec 8, 2021
stayseesong
approved these changes
Dec 8, 2021
Co-authored-by: stayseesong <[email protected]>
markzegarelli
approved these changes
Dec 9, 2021
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Sendgrid source documents are confusing and could lead to the mistaken belief that a Data Warehouse is NOT needed for certain types of events when in fact a DWH is always needed.
Merge timing
No rush