Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sprig action destination documentation #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2021
Merged

sprig action destination documentation #2266

merged 1 commit into from
Dec 10, 2021
+86 −0

Conversation

bgila
Copy link
Contributor

@bgila bgila commented Dec 10, 2021

Note -- I wasn't completely sure if I was supposed to create the yml file as well -- it seems like it should be possible to generate it from the action definition in the action-destinations repo. But happy to create it if needed!

Proposed changes

  • create documentation for initial Sprig action destination release

Merge timing

@bgila bgila requested a review from a team as a code owner December 10, 2021 20:52
@bgila bgila requested review from rchinn1 and removed request for a team December 10, 2021 20:52
@markzegarelli markzegarelli self-requested a review December 10, 2021 21:08
@markzegarelli markzegarelli added the new-integration Added a new source or destination label Dec 10, 2021
@markzegarelli
Copy link
Contributor

Hi @bgila. Thanks for the contribution! We actually just merged an update to our Action Destinations docs template, but I will apply those updates to this PR.

To answer your question, there is no need to generate the .yaml file. Our docs site will pull any relevant data directly from the destination.

@markzegarelli
Copy link
Contributor

@bgila, also, if possible, can you check the Allow edits from maintainers setting on the Pull Request, as described here?

@bgila
Copy link
Contributor Author

bgila commented Dec 10, 2021

@bgila, also, if possible, can you check the Allow edits from maintainers setting on the Pull Request, as described here?

hmm, sorry, I don't see how to enable this on this PR, or how to do it for a new one :( maybe i need some sort of permission to be able to change that setting?

Screen Shot 2021-12-10 at 5 17 16 PM

Screen Shot 2021-12-10 at 5 18 38 PM

@markzegarelli
Copy link
Contributor

@bgila No worries. I'll merge this into an intermediate branch, and we can make any edits we need to there. I'll tag you in that as well so you can keep eyes on it.

Thanks again for this contribution!

@markzegarelli markzegarelli changed the base branch from develop to sprig-actions December 10, 2021 23:06
@markzegarelli markzegarelli merged commit cfe89b4 into segmentio:sprig-actions Dec 10, 2021
@markzegarelli markzegarelli mentioned this pull request Dec 10, 2021
Merged
@bgila bgila deleted the bgila/sprig-action-dest branch December 13, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchinn1 rchinn1 Awaiting requested review from rchinn1 rchinn1 was automatically assigned from segmentio/segment-doc-team

@markzegarelli markzegarelli Awaiting requested review from markzegarelli

Assignees
No one assigned
Labels
new-integration Added a new source or destination
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgila @markzegarelli