Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add destinations from npm #5315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2023
Merged

add destinations from npm #5315

merged 2 commits into from
Sep 14, 2023

Conversation

stayseesong
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

@stayseesong stayseesong requested a review from a team as a code owner September 7, 2023 21:34
@stayseesong stayseesong requested review from forstisabella and removed request for a team September 7, 2023 21:34
@stayseesong stayseesong marked this pull request as draft September 7, 2023 21:35
@stayseesong stayseesong requested a review from zikaari September 7, 2023 21:35
@zikaari zikaari requested a review from silesky September 11, 2023 18:19
zikaari
zikaari approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@zikaari zikaari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tagging @silesky in case he has something to add as well

silesky
silesky requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@silesky silesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple comments ;-)

@stayseesong stayseesong marked this pull request as ready for review September 13, 2023 22:19
@stayseesong stayseesong merged commit 961fc59 into develop Sep 14, 2023
@stayseesong stayseesong deleted the DOC-727 branch September 14, 2023 21:12
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silesky silesky silesky approved these changes

@zikaari zikaari zikaari approved these changes

@forstisabella forstisabella forstisabella approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stayseesong @silesky @zikaari @forstisabella