Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update user-deletion-and-suppression guide.md #5340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

muhammadatifjav
Copy link
Contributor

Update User Deletion and Suppression guide

Proposed changes

There were some inconsistencies and missing details in the deletion and suppression guide, so I'm made some changes to mention Public API upfront, and then also add more details on what the UI shows and what Public API will show.

Merge timing

  • ASAP once approved

Related issues (optional)

https://segment.atlassian.net/browse/KCS-620

Update User Deletion and Suppression guide
added status and rephrased failed status sentence
@muhammadatifjav muhammadatifjav marked this pull request as ready for review September 18, 2023 06:00
@muhammadatifjav muhammadatifjav requested a review from a team as a code owner September 18, 2023 06:00
@muhammadatifjav muhammadatifjav requested review from rchinn1 and removed request for a team September 18, 2023 06:00
Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting @muhammadatifjav! A few minor suggestions to address, then I'll include this in our next deploy.

Copy link
Contributor Author

@muhammadatifjav muhammadatifjav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted all suggestions ! Thanks for all corrections Ryan!

@rchinn1 rchinn1 merged commit 45f8f2d into develop Sep 19, 2023
@rchinn1 rchinn1 deleted the user-deletion-suppression-guide-atif branch September 19, 2023 00:31
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants