Feature/upollo source #5346
Merged
Feature/upollo source #5346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchinn1
requested changes
Sep 14, 2023
Co-authored-by: rchinn-segment <[email protected]>
|
Hi @rchinn-segment, thank you so much for the great feedback. I've accepted it all. Some of that come from the documentation template though. So it might be good to update that too. Thanks. |
tcgilbert
suggested changes
Sep 15, 2023
tcgilbert
suggested changes
Sep 15, 2023
Co-authored-by: Thomas Gilbert <[email protected]>
rchinn1
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Hey @stephen-up Found a few more small edits, then this looks good to me.
Co-authored-by: rchinn-segment <[email protected]>
|
Thanks @rchinn-segment. All applied. |
rchinn1
approved these changes
Sep 18, 2023
|
Great, LGTM. I'll let @tcgilbert sign off on this before merging |
|
@rchinn-segment @stephen-up everything checks out! good to merge. |
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add documentation for the Upollo Source.
Note, we have a source that we are submitting for review.
https://app.segment.com/dev-portal/integrations/source/upollo-source/status
Merge timing
Thanks.