Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update privacy-portal.md with synonyms example #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

muhammadatifjav
Copy link
Contributor

Proposed changes

Added an example of synonyms as customers get confused on how to use this functionality works until you explain their specific use case.

Merge timing

  • ASAP once approved?

Related issues (optional)

https://segment.atlassian.net/browse/KCS-626

added screenshot for synonyms in privacy-portal.md
@muhammadatifjav muhammadatifjav marked this pull request as ready for review September 19, 2023 00:46
@muhammadatifjav muhammadatifjav requested a review from a team as a code owner September 19, 2023 00:46
@muhammadatifjav muhammadatifjav requested review from forstisabella and removed request for a team September 19, 2023 00:46
Comment on lines 228 to 232
The matchers scan data coming from your Sources for PII based on both
exact-matching (and fuzzy-matching if you select 'Similar to' option).
As an example, if you have a custom matcher for detecting "credit card
number", it will also detect variations like "credit-card number", or
typos such as "creditt card number".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @muhammadatifjav - given that we discuss matching in detail in the section immediately before this, I think we can remove this section.

Suggested change
The matchers scan data coming from your Sources for PII based on both
exact-matching (and fuzzy-matching if you select 'Similar to' option).
As an example, if you have a custom matcher for detecting "credit card
number", it will also detect variations like "credit-card number", or
typos such as "creditt card number".

Comment on lines 234 to 237
Our fuzzy matching uses [this public GitHub repository](https://github.com/imjasonmiller/godice)
to determine if it is a match. However, it will not detect all variations
and for those scenarios, you can use synonyms. You can add "credit card no",
"debit card number", or similar variations in the synonyms section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Our fuzzy matching uses [this public GitHub repository](https://github.com/imjasonmiller/godice)
to determine if it is a match. However, it will not detect all variations
and for those scenarios, you can use synonyms. You can add "credit card no",
"debit card number", or similar variations in the synonyms section.
Segment's exact matching and fuzzy matching do not detect all variations in the received keys
and for those scenarios, you can use synonyms. For example, for the value `credit card number`, you can add "credit card no",
"debit card number", or similar variations in the synonyms section to classify those fields.

I moved it below regex section - as regex section goes with custom matchers header
@forstisabella forstisabella merged commit a293225 into develop Sep 28, 2023
@forstisabella forstisabella deleted the privacy-portal-synonyms-example branch September 28, 2023 17:14
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants