Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Segment <> Shopify source #5847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Feb 9, 2024
Merged

Segment <> Shopify source #5847

merged 37 commits into from
Feb 9, 2024

Conversation

joe-ayoub-segment
Copy link
Contributor

Proposed changes

Adding a new Source doc for the new Segment Shopify Source. This Integration has been built internally and loads some JS code into a Shopify store. It then maps Shopify analytics events to Segment events.

Merge timing

The Source code needs to be approved by Shopify before this documentation can be made live. However perhaps we could register the Source in the Partner Portal and deploy the docs but not link to them yet?

Related issues (optional)

@joe-ayoub-segment joe-ayoub-segment requested a review from a team as a code owner January 5, 2024 11:37
@joe-ayoub-segment joe-ayoub-segment requested review from forstisabella and removed request for a team January 5, 2024 11:37
@joe-ayoub-segment
Copy link
Contributor Author

Hi @forstisabella - just checking what the next steps are. Is there anything else you need from me before this can be deployed (but kept hidden)?

@forstisabella
Copy link
Contributor

forstisabella commented Jan 5, 2024 •
edited
Loading

@joe-ayoub-segment I am working on a more comprehensive review: once that's complete (and you get the approval from @tcgilbert,) we can merge!

forstisabella
forstisabella requested changes Jan 5, 2024
View reviewed changes
@forstisabella forstisabella added the new-integration Added a new source or destination label Jan 5, 2024
joe-ayoub-segment and others added 12 commits January 7, 2024 11:08
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
52b7834 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
68f3437 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
a70ea77 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
687518d 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
074ed74 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
0be14a9 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
6eee560 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
71ac055 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
4582918 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
4204d4d 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment
Removing duplicate line
6eba385
@joe-ayoub-segment
Adding additional setup steps
4ef2b73
@forstisabella forstisabella self-requested a review January 22, 2024 17:25
@joe-ayoub-segment
Copy link
Contributor Author

hi @forstisabella can we deploy this live, but keep it unlinked please?
I'd like to be able to see the doc in Production without Google indexing it or customers finding it. Is this possible?

@forstisabella
Copy link
Contributor

Sure, we can do that! The hidden: true attribute will make this only accessible via direct link (segment.com/docs/connections/sources/catalog/libraries/website/shopify/).

If you could go through and accept/reject all remaining comments, we'll be good to merge this!

@forstisabella
Copy link
Contributor

you can also build the site locally following instructions in the devguide: https://github.com/segmentio/segment-docs/blob/develop/devguide.md

joe-ayoub-segment and others added 20 commits February 9, 2024 13:30
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
dc3ea09 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
65c9043 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
30e30f1 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
992e1b3 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
cb5ed71 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
cd56552 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
bef5a0a 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
91900a8 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
f681bef 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
dd4364e 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
fe25916 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
1670eea 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
762c8f1 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
458ac0a 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
091abc1 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
af07494 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
c04f70a 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
321520d 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
27fd28a 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment @forstisabella
Update src/connections/sources/catalog/libraries/website/shopify/inde…
c1c7d8a 
…x.md

Co-authored-by: forstisabella <[email protected]>
@joe-ayoub-segment
Copy link
Contributor Author

Hi @forstisabella I've accepted all the suggestions. Anything else to be done before this can be deployed?

@forstisabella
Copy link
Contributor

Nope, nothing else needs to be done to deploy it! I'll merge the PR today, but before this goes into public beta and beyond we'll need to make some updates to the id/other frontmatter!

@forstisabella forstisabella merged commit 8b5bcf3 into develop Feb 9, 2024
@forstisabella forstisabella deleted the shopify-source branch February 9, 2024 17:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

@forstisabella forstisabella mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forstisabella forstisabella forstisabella approved these changes

@tcgilbert tcgilbert Awaiting requested review from tcgilbert

Assignees
No one assigned
Labels
new-integration Added a new source or destination
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-ayoub-segment @forstisabella