Thanks to visit codestin.com
Credit goes to github.com

Skip to content

adding prereqs to readme #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2024
Merged

adding prereqs to readme #5878

merged 2 commits into from
Feb 16, 2024

Conversation

cmastr
Copy link
Contributor

@cmastr cmastr commented Jan 12, 2024

adding some prerequisites as I figure out which ones are needed.

@cmastr cmastr requested a review from a team as a code owner January 12, 2024 16:43
@cmastr cmastr requested review from stayseesong and removed request for a team January 12, 2024 16:43
@cmastr cmastr marked this pull request as draft January 12, 2024 16:44
@cmastr cmastr added the fixed-site A fix to the site itself that we want to communicate in a release label Jan 12, 2024
@cmastr cmastr marked this pull request as ready for review January 22, 2024 16:44
@cmastr
Copy link
Contributor Author

cmastr commented Jan 22, 2024

Taking out of draft mode, as review required to see what else might need to be added, or if any of this is untrue. Still need details about how to get make catalog to run.

@stayseesong
Copy link
Contributor

@cmastr rather than marking this with a "fixed-site" label, I feel like it should be labeled as "back-end". wdyt?

@cmastr cmastr added back-end fixes or updates to the site itself, which should not go in release notes and removed fixed-site A fix to the site itself that we want to communicate in a release labels Feb 5, 2024
@cmastr
Copy link
Contributor Author

cmastr commented Feb 5, 2024

@cmastr rather than marking this with a "fixed-site" label, I feel like it should be labeled as "back-end". wdyt?

This sounds good! Changed label. And added all of your comments.

@cmastr cmastr requested a review from stayseesong February 5, 2024 17:11
@cmastr cmastr merged commit b5bb7c2 into develop Feb 16, 2024
@cmastr cmastr deleted the co_update_readme_prerequs branch February 16, 2024 16:33
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end fixes or updates to the site itself, which should not go in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants