Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avo destination docs #6003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 13, 2024
Merged

Conversation

bjornj12
Copy link
Contributor

@bjornj12 bjornj12 commented Feb 7, 2024

Proposed changes

Adding documentation for new Avo destination

Merge timing

  • ASAP once approved? Yes

@bjornj12 bjornj12 requested a review from a team as a code owner February 7, 2024 09:46
@bjornj12 bjornj12 requested review from forstisabella and removed request for a team February 7, 2024 09:46
@bjornj12 bjornj12 changed the title Avo destination docs [WIP] Avo destination docs Feb 7, 2024
@bjornj12 bjornj12 marked this pull request as draft February 7, 2024 10:19
@forstisabella forstisabella added the new-integration Added a new source or destination label Feb 8, 2024
@bjornj12 bjornj12 changed the title [WIP] Avo destination docs Avo destination docs Feb 8, 2024
@bjornj12 bjornj12 marked this pull request as ready for review February 8, 2024 14:44
@bjornj12
Copy link
Contributor Author

bjornj12 commented Feb 8, 2024

Our slug in the destination is actions-avo https://app.segment.com/goto-my-workspace/destinations/catalog/actions-avo

However we'd love it if we could have /docs/connections/destinations/catalog/avo somehow, is that possible?

@tcgilbert
Copy link
Contributor

Our slug in the destination is actions-avo https://app.segment.com/goto-my-workspace/destinations/catalog/actions-avo

However we'd love it if we could have /docs/connections/destinations/catalog/avo somehow, is that possible?

@bjornj12 Within the Segment App UI, we link out to a hardcoded version of the docs url using the slug. But you could add a redirect to the markdown frontmatter:

redirect_from:
  - '/docs/connections/destinations/catalog/actions-avo/'

Additionally you would need to change the name of the parent folder from actions-avo/index.md to avo/index.md

@bjornj12
Copy link
Contributor Author

bjornj12 commented Feb 9, 2024

Our slug in the destination is actions-avo https://app.segment.com/goto-my-workspace/destinations/catalog/actions-avo
However we'd love it if we could have /docs/connections/destinations/catalog/avo somehow, is that possible?

@bjornj12 Within the Segment App UI, we link out to a hardcoded version of the docs url using the slug. But you could add a redirect to the markdown frontmatter:

redirect_from:
  - '/docs/connections/destinations/catalog/actions-avo/'

Additionally you would need to change the name of the parent folder from actions-avo/index.md to avo/index.md

This sounds exactly like what i want, ill check this out thanks!

@bjornj12
Copy link
Contributor Author

bjornj12 commented Feb 9, 2024

This is ready now then i believe, @tcgilbert 🙌

Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes and we'll be good to go!

Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one small change and we'll be ok to merge!

@bjornj12
Copy link
Contributor Author

@forstisabella is this ready to be merged? 🙌

@forstisabella forstisabella merged commit f559f27 into segmentio:develop Feb 13, 2024
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants