Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

shyaankhan
Copy link
Contributor

Proposed changes

Mixpanel team suggested these changes in order to make our Documentation around the Group call more accurate and clear.

@sanscontext
Copy link
Contributor

@shyaankhan I'm going to push a PR with copy edits directly to this branch.

Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with my copy edits. Waiting on a 👍from Steven.

Group calls are sent to Mixpanel if, **and only if**,

1. The Group Identifier Traits setting has one or more traits saved in the destination settings for Mixpanel.
![](images/mixpanel-group-id-traits.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno if it would take up too much space here, but it might be helpful to have a small follow-up screenshot of the setting page listing company_id as the Group Identifier Trait for this example (I've included one in the email)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenbaum Would you want the image you sent to replace the one that's currently there (the one that Cassie sent us) or would this be in addition? I think neither is the best since it's just a snapshot of a field without context, but if you think it'll help... 🤔

@stevenbaum
Copy link

Hey all - it looks good! I've left a couple comments on the file, and I've sent over a small screenshot that might be useful to include in our email thread.

Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey folks, I need to check on one thing before we merge this, sorry for the delay! Should have an answer by tomorrow.

@sanscontext
Copy link
Contributor

Got Steven all signed off, we're ready to merge if the image thing looks g2g!

@shyaankhan shyaankhan merged commit 55dc8fa into master Mar 18, 2020
@sanscontext sanscontext deleted the shyaankhan-mixpanel-1 branch March 19, 2020 18:42
bot-docsteam pushed a commit that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants