-
Notifications
You must be signed in to change notification settings - Fork 386
Updated Mixpanel Group call documentation #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@shyaankhan I'm going to push a PR with copy edits directly to this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with my copy edits. Waiting on a 👍from Steven.
Group calls are sent to Mixpanel if, **and only if**, | ||
|
||
1. The Group Identifier Traits setting has one or more traits saved in the destination settings for Mixpanel. | ||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno if it would take up too much space here, but it might be helpful to have a small follow-up screenshot of the setting page listing company_id
as the Group Identifier Trait for this example (I've included one in the email)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevenbaum Would you want the image you sent to replace the one that's currently there (the one that Cassie sent us) or would this be in addition? I think neither is the best since it's just a snapshot of a field without context, but if you think it'll help... 🤔
Hey all - it looks good! I've left a couple comments on the file, and I've sent over a small screenshot that might be useful to include in our email thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey folks, I need to check on one thing before we merge this, sorry for the delay! Should have an answer by tomorrow.
Got Steven all signed off, we're ready to merge if the image thing looks g2g! |
…RLs [DC-265] (#700) Co-authored-by: Mohamed K. Coulibali <[email protected]>
Proposed changes
Mixpanel team suggested these changes in order to make our Documentation around the Group call more accurate and clear.