Feat/template cron column - #4106
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesTemplate schedule display
Docs subproject update
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant TemplatesView
participant SchedulesResource
participant TemplatesTable
TemplatesView->>SchedulesResource: fetch project schedules
SchedulesResource-->>TemplatesView: return schedule records
TemplatesView->>TemplatesTable: render timezone-aware cron values
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
web/src/views/project/Templates.vue (1)
284-301: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winRun and address the frontend lint failures.
web && npm run lintexits with lint errors, including dependency/import errors inweb/gulp-gpt-translate.jsandweb/vue.config.js; ignoring known console/asset-size warnings is not applicable here.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/src/views/project/Templates.vue` around lines 284 - 301, Run the frontend lint command and resolve every reported error, prioritizing dependency/import failures in gulp-gpt-translate.js and vue.config.js. Correct invalid or missing imports and any related dependency configuration, then address remaining lint errors such as unused or misordered imports in Templates.vue. Do not suppress errors or treat console/asset-size warnings as acceptable.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@web/src/views/project/Templates.vue`:
- Around line 284-301: Run the frontend lint command and resolve every reported
error, prioritizing dependency/import failures in gulp-gpt-translate.js and
vue.config.js. Correct invalid or missing imports and any related dependency
configuration, then address remaining lint errors such as unused or misordered
imports in Templates.vue. Do not suppress errors or treat console/asset-size
warnings as acceptable.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: da2152b0-1daa-4973-8802-a1ef1554e1cf
📒 Files selected for processing (2)
docsweb/src/views/project/Templates.vue
There was a problem hiding this comment.
Pull request overview
Adds a new “Cron” column on the Project → Templates table so users can quickly see each template’s schedule(s), including “run once” (run_at) schedules formatted in the configured system timezone (issue #1794).
Changes:
- Add a
crontable column with per-template schedule rendering (cron format or formattedrun_at). - Load project
schedulesalongside inventory/environment/repositories and gate page readiness on it. - Add Day.js timezone formatting support and use
systemInfo.schedule_timezonewhen formattingrun_at.
| getTemplateSchedules(item) { | ||
| return (this.schedules || []).filter((s) => s.template_id === item.id); | ||
| }, |
fix issue #1794
Summary by CodeRabbit
New Features
Chores