-
Notifications
You must be signed in to change notification settings - Fork 49
feat: core RPC scanning #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this ready for review? |
8ad5cd4
to
6ffcae3
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
@brandonspark I'd suggest we don't link Slack conversations here since this repo is public and people may not want to sign up for slack to see this. |
dcfdde8
to
0ae79c6
Compare
I was about to review and merge this PR now that Semgrep 1.131.0 is out. However, after making a small change (capitalizing the global constants per the discussion in #80), I realized that CI started breaking. I made the following changes to make CI pass:
Since I have made some additional changes, I feel like I can't just merge the change right now, and would love if someone could take a look at this before I merge it to |
Updated to a video instead! |
What:
This PR adds the ability to invoke a command across RPC to
semgrep mcp
to scan a file, rather than spinning up a whole CLI.Why:
It's hella faster.
How:
We used the logic that we built out in #80 and added a new command,
scanFiles
, which allows us to scan some files.Test plan:
vid.mov