Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix unclosed version file warning #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

demianbrecht
Copy link

Fixes

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] I have added necessary documentation about the functionality in the appropriate .md file
  • [] I have added in line documentation to the code I modified

Short description of what this PR does:

Tiny fix that removes the following unclosed file warning:

python -Wd -m unittest discover -v
/src/spython-http-client/python_http_client/__init__.py:22: ResourceWarning: unclosed file <_io.TextIOWrapper name='/src/python-http-client/python_http_client/VERSION.txt' mode='r' encoding='UTF-8'>
  __version__ = open(os.path.join(dir_path, 'VERSION.txt')).read().strip()

If you have questions, please send an email to the Twilio SendGrid Developer Experience Team, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 5, 2019
@SendGridDX
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@childish-sambino
Copy link
Contributor

Duplicates #128

@childish-sambino childish-sambino added status: duplicate duplicate issue and removed status: code review request requesting a community code review or review from Twilio labels Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate duplicate issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants