Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support timeout #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2018
Merged

Support timeout #21

merged 2 commits into from
May 22, 2018

Conversation

georgeyk
Copy link
Contributor

@georgeyk georgeyk commented Oct 1, 2017 •
edited
Loading

A work-in-progress fix for #20

We can use timeout in the client scope, so it will apply the given timeout value for all requests and/or by specific request call (the request timeout will take precedence over the client timeout configuration`).

# client timeout
python_http_client.Client(host=host, timeout=3)
response = client.search.get(...)  # timeout=3
response = client.search.get(..., timeout=5)  # will use timeout=5

I need to improve the tests, but I'll wait for the initial feedback.

@SendGridDX
Copy link

SendGridDX commented Oct 1, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@georgeyk
Copy link
Contributor Author

georgeyk commented Oct 1, 2017

Looking at https://travis-ci.org/sendgrid/python-http-client/jobs/281829725 it is not related with the changes in PR (or at least, not obviously related - something in distutils 😢 ).

@thinkingserious
Copy link
Contributor

We are removing support for v2.6, so no worries :)

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 1, 2017
@georgeyk
Copy link
Contributor Author

georgeyk commented Oct 3, 2017

Any feedback here ?
I was looking to the tests, but I'm not sure if this change is entirely testable in the current structure.

@thinkingserious
Copy link
Contributor

Hi @georgeyk,

My apologies, this issue is still on my backlog for review. I hope to review it soon.

With Best Regards,

Elmer

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 17, 2017
@thinkingserious
Copy link
Contributor

Hello @georgeyk,

This PR finally came up on my backlog :)

I tried to fix the conflicts, but GitHub is not happy :( Do you mind fixing them? Otherwise, this PR looks good to go.

With Best Regards,

Elmer

@georgeyk
Copy link
Contributor Author

georgeyk commented Jan 8, 2018

Hi @thinkingserious,

I'm sorry about the late response, but I finally managed to update the PR.

@thinkingserious
Copy link
Contributor

Thanks @georgeyk!

@thinkingserious thinkingserious added the type: community enhancement feature request not on Twilio's roadmap label Feb 27, 2018
@thinkingserious thinkingserious merged commit 70797c3 into sendgrid:master May 22, 2018
@thinkingserious
Copy link
Contributor

Hello @georgeyk,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious thinkingserious mentioned this pull request May 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@georgeyk @SendGridDX @thinkingserious @apigirl